Fix Mensa Parser #122
Merged
Fix Mensa Parser #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mensa parser is currently crashing our bot daily. This is due to the underlying library,
ka-mensa-fetch, currently being unable to fetch mensa data, most likely since the website changed in some way. Fixing the underlying issue in the library is not feasable for us right now, and hoping for a library fix seems unlikely aswell, since the last release was several months ago, and the latest commits were only dependency updates.This PR currently just disables the mensa plan, as a quick fix. We can also use this PR to discuss the future of the mensa feature, since I'm currently unsure if we still need/want to support it, and how we should go about fixing it.
@Kr0nox @ProgramPhoenix